Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document rpc config until exit-on-server-eof #161

Merged
merged 1 commit into from
May 18, 2024

Conversation

ben-grande
Copy link
Contributor

* exit-on-client-eof:
* Description: Exit when the client shuts down its input stream, client
sends EOF to stdin.
* Conflicting options: if set to 'true', cannot set the 'user' option.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Conflicting options: if set to 'true', cannot set the 'user' option.
* Conflicting options: if set to 'true', cannot set the 'force-user' option.

* exit-on-service-eof:
* Description: Exit when the service shuts down its output stream,
service sends EOF to stdout.
* Conflicting options: if set to 'true', cannot set the 'user' option.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Conflicting options: if set to 'true', cannot set the 'user' option.
* Conflicting options: if set to 'true', cannot set the 'force-user' option.

* Description: Skip sending service descriptor and go for the actual
data directly. Useful to skip sending metadata to socket-based
services.
* Conflicting options: if set to 'true', cannot set the 'user' option.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Conflicting options: if set to 'true', cannot set the 'user' option.
* Conflicting options: if set to 'true', cannot set the 'force-user' option.

Copy link

codecov bot commented May 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.93%. Comparing base (43f49f0) to head (5ced777).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #161      +/-   ##
==========================================
- Coverage   77.95%   77.93%   -0.02%     
==========================================
  Files          54       54              
  Lines        9616     9618       +2     
==========================================
  Hits         7496     7496              
- Misses       2120     2122       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marmarek marmarek merged commit 9a8b9c2 into QubesOS:main May 18, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants