Fix SIGUSR1 after stdin_fd closed #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this fails to build |
|
Build fixed and tests added. |
DemiMarie
force-pushed
the
fix-shutdown
branch
2 times, most recently
from
a70c63b to
2d2284e
Compare
|
the (new) test failed |
Just shut it down for writing, and save it so that it can later be used for reading. This also ensures deterministic behavior when --use-stdin-socket is used. Previously, the socket would be shut down for reading or writing but not both, depending on whether reading or writing stopped first. This could be quite confusing for callers. Instead, always shut down the socket for both reading and writing, guaranteeing deterministic behavior. This partially reverts a3bbcb5 ("Prefer close() to shutdown()"): the change to use close() is reverted, but the substantial simplification of the code is not. Fixes: a3bbcb5 ("Prefer close() to shutdown()") Fixes: QubesOS/qubes-issues#9183
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #157 +/- ##
==========================================
+ Coverage 77.78% 77.82% +0.04%
==========================================
Files 54 54
Lines 9496 9536 +40
==========================================
+ Hits 7386 7421 +35
- Misses 2110 2115 +5 ☔ View full report in Codecov by Sentry. |
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.2&build=2024050300-4.2&flavor=pull-requests New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.2&build=2024050210-4.2&flavor=update
Failed tests7 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/98585#dependencies 1 fixed
Unstable tests
|
marmarek
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just shut it down for writing, and save it so that it can later be used for reading.
This also ensures deterministic behavior when --use-stdin-socket is used. Previously, the socket would be shut down for reading or writing but not both, depending on whether reading or writing stopped first. This could be quite confusing for callers. Instead, always shut down the socket for both reading and writing, guaranteeing deterministic behavior.
Fixes: a3bbcb5 ("Prefer close() to shutdown()")
Fixes: QubesOS/qubes-issues#9183