Allow equal sign and coma in feature requests #665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #665 +/- ##
==========================================
+ Coverage 69.75% 69.84% +0.09%
==========================================
Files 58 59 +1
Lines 12550 12581 +31
==========================================
+ Hits 8754 8787 +33
+ Misses 3796 3794 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025030301-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025021804-4.3&flavor=update
Failed tests11 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/129058#dependencies 15 fixed
Unstable testsPerformance TestsPerformance degradation:31 performance degradations
Remaining performance tests:41 tests
|
This was referenced Feb 27, 2025
Merged
|
@ArrayBolt3 any other characters missing, that you'd see used in kernelopts for a boot mode? |
|
Wrote a quick script to tell me all of the characters in Kicksecure's kernel command line, one character that might be needed in the future but I don't believe is needed now is the comma ( |
It is necessary for boot mode feature, as a common characters in kernelopts. QubesOS/qubes-issues#9750
marmarek
force-pushed
the
feature-request-equal
branch
from
ebdaf6c to
60ed744
Compare
marmarek
changed the title
This was referenced Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is necessary for boot mode feature, as a common character in
kernelopts
QubesOS/qubes-issues#9750