Improve qvm-volume tool #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows to get and set volumes properties. Fixes QubesOS/qubes-issues#3256
Codecov Report
@@ Coverage Diff @@
## master #60 +/- ##
==========================================
+ Coverage 74.92% 75.21% +0.28%
==========================================
Files 47 47
Lines 5269 5338 +69
==========================================
+ Hits 3948 4015 +67
- Misses 1321 1323 +2
Continue to review full report at Codecov.
|
marmarta
added a commit
to marmarta/qubes-desktop-linux-manager
that referenced
this pull request
Mar 19, 2018
Added an auto-starting disk space widget. It warns the user if there's less than 5% free in any pool. (Further improvements, like configurable warning threshold, will come). Depends on QubesOS/qubes-core-admin-client#60
marmarta
added a commit
to marmarta/qubes-desktop-linux-manager
that referenced
this pull request
Mar 19, 2018
Added an auto-starting disk space widget. It warns the user if there's less than 5% free in any pool. (Further improvements, like configurable warning threshold, will come). Depends on QubesOS/qubes-core-admin-client#60
marmarta
added a commit
to marmarta/qubes-desktop-linux-manager
that referenced
this pull request
Mar 19, 2018
Added an auto-starting disk space widget. It warns the user if there's less than 5% free in any pool. (Further improvements, like configurable warning threshold, will come). Depends on QubesOS/qubes-core-admin-client#60
marmarta
added a commit
to marmarta/qubes-desktop-linux-manager
that referenced
this pull request
Mar 19, 2018
Added an auto-starting disk space widget. It warns the user if there's less than 5% free in any pool. (Further improvements, like configurable warning threshold, will come). Depends on QubesOS/qubes-core-admin-client#60
marmarta
added a commit
to marmarta/qubes-desktop-linux-manager
that referenced
this pull request
Mar 19, 2018
Added an auto-starting disk space widget. It warns the user if there's less than 5% free in any pool. (Further improvements, like configurable warning threshold, will come). Depends on QubesOS/qubes-core-admin-client#60 fixes QubesOS/qubes-issues#3240 references QubesOS/qubes-issues#3241
And return None (instead of raising KeyError) when pool driver does not provide such information.
Use *VMNAME:VOLUME* instead of *POOL_NAME:VOLUME_ID*, because this is the default form.
marmarek
force-pushed
the
qvm-volume-actions
branch
2 times, most recently
from
1e72d33 to
46a8bb9
Compare
Right now Admin API backend will refuse to shrink volume anyway, but we're planning to relax this restriction. Make sure the client side (qvm-volume tool here, GUI VM settings already have this in place) will employ appropriate safety check. QubesOS/qubes-issues#3725
marmarek
force-pushed
the
qvm-volume-actions
branch
from
46a8bb9 to
70b15c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The final part for volume snapshots handling, especially revisions_to_keep
setting. This also adds an option to get more information about a single volume
(size, usage, available revisions etc).
Fixes QubesOS/qubes-issues#3256