Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --version #321

Merged
merged 1 commit into from
Jan 2, 2025
Merged

Add --version #321

merged 1 commit into from
Jan 2, 2025

Conversation

alimirjamali
Copy link
Contributor

@alimirjamali alimirjamali commented Nov 16, 2024

@alimirjamali
Copy link
Contributor Author

alimirjamali commented Nov 17, 2024

@marmarek
I am adding --version to all qvm-* and qubes-* utilities. Builder2 fails. I believe it fails since it does not provide .egg-info directory. I am not a builder2 expert. Advise is highly appreciated.

p.s.: OK. I see it is Sphinx build that is failing. Not exactly builder2 fault. It runs before installation. And I have no idea some ideas on how to fix it (fixed).

@alimirjamali alimirjamali force-pushed the version branch 3 times, most recently from 35c5039 to b6820de Compare November 17, 2024 08:25
Copy link

codecov bot commented Nov 17, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 75.27%. Comparing base (2a57695) to head (1ce556b).
Report is 21 commits behind head on main.

Files with missing lines Patch % Lines
qubesadmin/tools/__init__.py 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #321      +/-   ##
==========================================
+ Coverage   75.24%   75.27%   +0.03%     
==========================================
  Files          52       52              
  Lines        8950     8959       +9     
==========================================
+ Hits         6734     6744      +10     
+ Misses       2216     2215       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alimirjamali alimirjamali marked this pull request as draft November 17, 2024 10:09
@alimirjamali alimirjamali force-pushed the version branch 3 times, most recently from 5fcdeb2 to 3a85793 Compare November 17, 2024 14:06
@alimirjamali alimirjamali marked this pull request as ready for review November 17, 2024 14:08
@marmarek marmarek merged commit 5ad9f04 into QubesOS:main Jan 2, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add --version to qvm-* and qubes-* programs
2 participants