Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.6.0] Implement hit object timing groups #4293

Closed
wants to merge 46 commits into from

Conversation

WilliamQiufeng
Copy link
Member

@WilliamQiufeng WilliamQiufeng commented Sep 20, 2024

Requires Quaver/Quaver.API#186

Changes:

  • New Timing Group editing panel which allows:
    • Create/Delete timing groups
    • Rename timing groups
    • Change timing group color
    • Button to go to SV editing for the timing group
  • SV Editor:
    • Now allows editing SVs in different scroll groups
  • Editor view:
    • Hit objects can now be colored by timing group
    • The selected tab in SV editor is the current timing group we're working on
    • SV addition/deletion will take place in the selected timing group by default if the action's timing group parameter is null
    • The SV green lines will only show the SVs in the selected scroll group

Issues:

  • Spam of events on color change
  • SV plugins will take affect in the selected scroll group in SV Editor
  • SV Lines will only show the SVs in the selected group
quaver-timinggroup-sv-2-compressed.mp4

@WilliamQiufeng WilliamQiufeng marked this pull request as draft September 20, 2024 15:35
@WilliamQiufeng WilliamQiufeng marked this pull request as ready for review September 25, 2024 06:38
@WilliamQiufeng WilliamQiufeng changed the title Implement hit object timing groups [1.6.0] Implement hit object timing groups Sep 25, 2024
@WilliamQiufeng
Copy link
Member Author

Superseded by #4305 and #4306

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants