Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lmfit 1.3.0/1.3.1 serialization restore bug #720

Closed
stuart-cls opened this issue May 10, 2024 · 0 comments · Fixed by #731
Closed

lmfit 1.3.0/1.3.1 serialization restore bug #720

stuart-cls opened this issue May 10, 2024 · 0 comments · Fixed by #731
Labels
bug upstream

Comments

@stuart-cls
Copy link
Member

Only seems to affect the Voigt and SkewedVoigt models. Probably easiest just to wait for the fix to be released.

This is why the peakfit tests are failing, it would be better if they failed more explicitly.

lmfit/lmfit-py#956
stuart-cls added a commit to stuart-cls/orange-spectroscopy that referenced this issue May 10, 2024
@stuart-cls
[TEST] Add a test to check peakfit_compute.pool_initializer restore
7c0f6c8 
Related: Quasars#720
@stuart-cls stuart-cls mentioned this issue May 10, 2024
Merged
@stuart-cls stuart-cls mentioned this issue Jul 19, 2024
Merged
stuart-cls added a commit to stuart-cls/orange-spectroscopy that referenced this issue Jul 19, 2024
@stuart-cls
[FIX] Bump lmfit version to 1.3.2
6b256fb 
Closes Quasars#720
@stuart-cls stuart-cls mentioned this issue Jul 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug upstream
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[FIX] Bump lmfit version to 1.3.2 stuart-cls/orange-spectroscopy
1 participant
@stuart-cls