Retrieve address from KMS #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qizhou
approved these changes
Feb 25, 2025
| if err != nil { | ||
| return nil, fmt.Errorf("kms get public key request failed: %w", err) | ||
| } | ||
| fmt.Printf("PEM:\n%s", result.Pem) |
There was a problem hiding this comment.
Are these prints intended to be in the final output or just for debug? Similar for L40.
There was a problem hiding this comment.
If it's only for debug, then it should be commented out, right?
There was a problem hiding this comment.
As an internal tool, it is convenient and informative for the user to check whether each step is correct or not.
blockchaindevsh
approved these changes
Feb 27, 2025
This was referenced Mar 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get addresses based on the KMS config for client usage.