Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPD: rank_size usage in respective lectures #231

Merged
merged 2 commits into from
Jul 2, 2020

Conversation

bktaha
Copy link
Contributor

@bktaha bktaha commented Jun 16, 2020

Following discussion in this quantecon-py issue, update all lectures using the rank_size_plot method of the inequality.py module to work with the refactored version rank_size, as per this PR.

The following lectures have been edited

  • Heavy-Tailed Distributions
  • Wealth Distribution Dynamics
  • Kesten Processes and Firm Dynamics

@mmcky
Copy link
Contributor

mmcky commented Jun 17, 2020

@bktaha thanks for this PR. Can you update your fork with the latest master. There is a bug in the Github Action used for fetching changed files where it breaks if the current master is ahead of the downstream fork.

@mmcky
Copy link
Contributor

mmcky commented Jun 17, 2020

@jstac
Copy link
Contributor

jstac commented Jun 17, 2020

Great job @bktaha , many thanks. This is very nice, careful work.

If you like, please contact me by email to tell my what you're studying and what your plans are.

You can find my contact details here.

@mmcky , I've looked over this and approve, conditional on checks passing. I would be grateful if you could handle the coordinated merge.

@bktaha
Copy link
Contributor Author

bktaha commented Jun 18, 2020

@jstac
Thank you for the kind comments, and for being so welcoming!

@mmcky
I updated my fork with the latest master and as you pointed out, all checks except for execution are successful.

@mmcky
Copy link
Contributor

mmcky commented Jun 18, 2020

thanks @bktaha I will issue a new release of QuantEcon.py and then re-run the tests before merging.

@mmcky
Copy link
Contributor

mmcky commented Jul 2, 2020

thanks again @bktaha -- this now passes tests with the release of quantecon=0.4.8.

@mmcky mmcky merged commit 97ec5ac into QuantEcon:master Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants