Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for Broken Examples ... #94

Merged
merged 3 commits into from
Nov 6, 2014
Merged

Fixes for Broken Examples ... #94

merged 3 commits into from
Nov 6, 2014

Conversation

sanguineturtle
Copy link
Contributor

Opening a PR to track small fixes to broken examples (largely due to interface changes):

  1. career_vf_plot.py [fix issued]
  2. mc_convergence_plot.py [see issue [Examples] mc_convergence_plot.py IndexError #93]

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling c3f35e1 on examplefixes into 702abc1 on master.

@sanguineturtle
Copy link
Contributor Author

Pushed fix to mc_compute_stationary.

@jstac This PR contains two small changes to fix the examples listed above. This is now OK to merge once Travis CI reports back.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 773990a on examplefixes into 702abc1 on master.

@sanguineturtle
Copy link
Contributor Author

@jstac I have added a minor adjustment to the current ipython notebook for the finite_mc_solutions.ipynb notebook to fix the index issue. However as documented in Issue #93 @oyamad has an updated notebook where irreducibility and aperiodicity are examined.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 773990a on examplefixes into 702abc1 on master.

jstac added a commit that referenced this pull request Nov 6, 2014
Fixes for Broken Examples ...
@jstac jstac merged commit 933e9cc into master Nov 6, 2014
@jstac jstac deleted the examplefixes branch November 6, 2014 05:40
@jstac
Copy link
Contributor

jstac commented Nov 6, 2014

@sanguineturtle Many thanks. The build is failing but it's due to a Python 3 issue caused by my changes. I'll accept your PR and fix the build problem separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants