ENH: don't solve linear system twice in a row #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstac
added a commit
that referenced
this pull request
Jun 28, 2014
ENH: don't solve linear system twice in a row
|
Thanks Spencer. |
jstac
added a commit
that referenced
this pull request
Aug 25, 2014
ENH: don't solve linear system twice in a row
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an extremely minor change.
On line 120 we write
self.F = solve(S1, S2). Then on line 122 we callsolve(S1, S2)again. This change just reuses the updated value ofself.Finstead of recomputing.All the other changes that show up in the diff are just my editor removing trailing whitespace from lines.