Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LGTM code quality badges #430

Merged
merged 1 commit into from
Oct 6, 2018
Merged

Add LGTM code quality badges #430

merged 1 commit into from
Oct 6, 2018

Conversation

xcorail
Copy link
Contributor

@xcorail xcorail commented Sep 5, 2018

Hi there!

I thought you might be interested in adding these code quality badges to your project. They will indicate a very high code quality to potential users and contributors.
To get an idea of the analyses reflected by these grades, check the alerts discovered by LGTM.

N.B.: I am on the team behind LGTM.com, I'd appreciate your feedback on this initiative, whether you're interested or not, if you find time to drop me a line. Thanks.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.163% when pulling 6fdd9f6 on xcorail:master into 2a5b114 on QuantEcon:master.

@mmcky
Copy link
Contributor

mmcky commented Sep 11, 2018

hey @xcorail thanks for the PR. Your project looks pretty neat -- I will take a closer look this week.

@mmcky mmcky added the ready label Sep 11, 2018
@xcorail
Copy link
Contributor Author

xcorail commented Sep 11, 2018

Hey @mmcky

Hope you'll find it useful!
Some precisions on how / when the analysis is triggered:

  • The recommended usage is to activate PR integration. LGTM will then analyse the PR immediately and report any new problem (or fix) directly within the PR. It's a one-click operation
  • Otherwise LGTM polls your repo once a day and analyses all commits, most recent first

Cheers

@mmcky
Copy link
Contributor

mmcky commented Sep 12, 2018

thanks @xcorail -- I will check that out the integration.

@mmcky mmcky merged commit c319203 into QuantEcon:master Oct 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants