Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RBLQ: add pure forecasting case #355

Merged
merged 5 commits into from
Oct 23, 2017
Merged

RBLQ: add pure forecasting case #355

merged 5 commits into from
Oct 23, 2017

Conversation

szokeb87
Copy link
Contributor

Adds the following case:
If Q and B are zero matrices, RBLQ assumes that the user wants to solve a "pure forecasting problem" defined on p171 in Robustness (Hansen and Sargent, 2008).

It is assumed that the user sets up the problem in a way that "eliminates" F. This involves redefining the R and A matrices in equations (1) and (2) (of this lecture) as
R_adj = R + F'QF
A_adj = A - BF
Then, using R_adj, A_adj, C with Q=B=0 (zero matrices), RBLQ returns a K which is the worst-case with respect to the proposed policy F.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.07%) to 94.767% when pulling 05cbb3c on szokeb87:master into 707f8aa on QuantEcon:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.07%) to 94.767% when pulling 776a8bf on szokeb87:master into 707f8aa on QuantEcon:master.

@jstac
Copy link
Contributor

jstac commented Oct 22, 2017

@szokeb87 Many thanks.
@mmcky For background, @szokeb87 has added this functionality in response to

http://discourse.quantecon.org/t/robust-lqc-special-case/281

@mmcky
Copy link
Contributor

mmcky commented Oct 22, 2017

Thanks @szokeb87. Can we please add this case to the test_robustlq suite?

@mmcky mmcky added the in-work label Oct 23, 2017
@szokeb87
Copy link
Contributor Author

@mmcky Done

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 94.855% when pulling 245670c on szokeb87:master into 707f8aa on QuantEcon:master.

@@ -1,8 +1,8 @@
"""
Author: Chase Coleman
Copy link
Member

@cc7768 cc7768 Oct 23, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like your name should be added here 😉

@szokeb87
Copy link
Contributor Author

@cc7768 this was just the cherry on the cake :)

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 94.855% when pulling 2aa5e6c on szokeb87:master into 707f8aa on QuantEcon:master.

@mmcky mmcky added ready and removed in-work labels Oct 23, 2017
@mmcky
Copy link
Contributor

mmcky commented Oct 23, 2017

Thanks @szokeb87 this is looking great.

@mmcky mmcky merged commit befc673 into QuantEcon:master Oct 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants