Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add simplex tools #183

Merged
merged 3 commits into from
Oct 23, 2017
Merged

ENH: Add simplex tools #183

merged 3 commits into from
Oct 23, 2017

Conversation

cc7768
Copy link
Member

@cc7768 cc7768 commented Oct 22, 2017

Based on the QuantEcon.py code from QuantEcon/QuantEcon.py#344

Also would close #178

@codecov-io
Copy link

codecov-io commented Oct 22, 2017

Codecov Report

Merging #183 into master will increase coverage by 0.15%.
The diff coverage is 96.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #183      +/-   ##
==========================================
+ Coverage   90.54%   90.69%   +0.15%     
==========================================
  Files          24       24              
  Lines        1607     1633      +26     
==========================================
+ Hits         1455     1481      +26     
  Misses        152      152
Impacted Files Coverage Δ
src/util.jl 95.65% <96.15%> (+2.62%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f44a76d...24a97f4. Read the comment docs.

Copy link
Member

@oyamad oyamad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, the code looks good to me, except that test_util is missing in runtests.jl.

@sglyon sglyon merged commit 6310172 into master Oct 23, 2017
oyamad referenced this pull request in QuantEcon/GameTheory.jl Nov 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add simplex_grid and simplex_index
4 participants