Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Code Smell Type proposal #54

Closed
charlesmorin opened this issue Jan 18, 2017 · 6 comments
Closed

New Code Smell Type proposal #54

charlesmorin opened this issue Jan 18, 2017 · 6 comments
Assignees
Milestone

Comments

@charlesmorin
Copy link

As discussed in the Google group thread, please add the following smell types:

  • non compliance with team standard or convention (NOT_COMPLIANT_TO_STANDARD)
  • missing mandatory test (MISSING_MANDATORY_TEST)
  • missing mandatory javadoc (MISSING_MANDATORY_JAVADOC)
  • catch all type (OTHER)

Thread URL:
https://groups.google.com/forum/#!topic/code-smells/F2X9fA2zmgM

Cheers

@charlesmorin charlesmorin changed the title New Code Smell Type proposition New Code Smell Type proposal Jan 18, 2017
@pawlakm
Copy link
Member

pawlakm commented Jan 19, 2017

Hi Charles,

As further discussed by mail, I'll create the following types :

  • NON_COMPLIANCE_WITH_STANDARDS
  • MISSING_TEST
  • MISSING_DOCUMENTATION
  • OTHER

@pawlakm pawlakm self-assigned this Jan 19, 2017
@pawlakm pawlakm added this to the 4.0.0 milestone Jan 19, 2017
pawlakm added a commit that referenced this issue Jan 19, 2017
@pawlakm
Copy link
Member

pawlakm commented Jan 19, 2017

4.0.0-RC2-SNAPSHOT is working fine on latest LTS (with latest java plugin). Here is a screenshot of the widget:

screen shot 2017-01-19 at 21 36 45

pawlakm added a commit that referenced this issue Jan 19, 2017
@pawlakm
Copy link
Member

pawlakm commented Jan 19, 2017

Hi Charles,

To answer your question, version 4.0.0 is compatible with current LTS (5.6.x, tested with 5.6.4) and depends on java 4.4 plugin. See the requirements part of the documentation.

Can you please check if you agree with the default severity levels of the new smell types ?

Thanks in advance,

Michel

@pawlakm
Copy link
Member

pawlakm commented Jan 19, 2017

The plugin seems to work fine with SQ 6.2 as well. However, project dashboards having been removed by SonarSource, custom widget cannot be used anymore... Measure counting Code Smells reported by the plugin can however be seen in the "Measures" tab ("Code Smells" and "Technical Debt" sections). It's better than nothing, but it's ways less readable than a donut diagram...

@charlesmorin
Copy link
Author

I'm good with the default severity levels. Makes perfect sense to me.

Thank you

@pawlakm
Copy link
Member

pawlakm commented Jan 20, 2017

Great, I close this issue then. I'll create a new RC this evening after having finished working on #56.

@pawlakm pawlakm closed this as completed Jan 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants