[SDS-335] Resolve import cycles using postponed annotations #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
QFer
requested changes
Mar 14, 2022
|
@tomrijnbeek This comment is not intended as a review of this PR. But python does have abstract classes as part of the standard library: https://docs.python.org/3/library/abc.html |
Postponed annotations allow us to use forward code references without having access to them statically, but we can have access at runtime. Using the TYPE_CHECKING constant from typing makes sure that we don't have circular dependencies in the actual code. The "correct" approach would be to extract interfaces. For example, we could have a generic API interface or a generic Job interface that exposes the methods and properties that we need access to. However, this is not particularly "Pythonese", so this approach seemed more lightweight.
tomrijnbeek
force-pushed
the
feature/SDS-335/postponed-annotations
branch
from
e359fe7 to
5f48413
Compare
tomrijnbeek
force-pushed
the
feature/SDS-335/postponed-annotations
branch
from
5f48413 to
cd52e55
Compare
QFer
approved these changes
Mar 17, 2022
oschusler
pushed a commit
that referenced
this pull request
Feb 2, 2025
Bumps [qutechopenql](https://github.com/QuTech-Delft/OpenQL) from 0.11.1 to 0.12.2. - [Release notes](https://github.com/QuTech-Delft/OpenQL/releases) - [Changelog](https://github.com/QuTech-Delft/OpenQL/blob/develop/CHANGELOG.md) - [Commits](QuTech-Delft/OpenQL@v0.11.1...0.12.2) --- updated-dependencies: - dependency-name: qutechopenql dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Postponed annotations allow us to use forward code references without having access to them statically, but we can have access at runtime. Using the TYPE_CHECKING constant from typing makes sure that we don't have circular dependencies in the actual code.
The "correct" approach would be to extract interfaces. For example, we could have a generic API interface or a generic Job interface that exposes the methods and properties that we need access to. However, this is not particularly "Pythonese", so this approach seemed more lightweight.