-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor UX481FA ACPI #19
Conversation
- Add source DSL w/ comments - Add source ACPI renames as plist
- Add source DSL w/ comments - Add source ACPI renames as plist
Original fix addresses Reboot instead of Shutdown issue, but this issue is not present. Changes: - Removed _PTS to ZPTS ACPI rename - Removed SSDT-PTS
Companion SSDT for CodecCommander (not needed) - Removed HDAS to HDEF rename as it is already handled by AppleALC.
Patch is from Rehabman but is not functional; only cosmetic.
- Source DSL moved to Resources folder
- TODO: Add source DSL w/ comments - TODO: Add source ACPI renames as plist
- Added source DSL w/ comments - TODO: add source ACPI renames as plist
Will defer users to use the USBToolbox method instead of relying on an ACPI patch for mapping USB personalities should this be similarly prone to change. Otherwise a note should be given somewhere to remove the respective SSDT sans any internal USB personalities w/ the appropriate instructions. This may also require the following ACPI rename to avoid errors: <dict>
<key>Comment</key>
<string>XHC: _UPC to XUPC</string>
<key>Count</key>
<integer>0</integer>
<key>Enabled</key>
<true/>
<key>Find</key>
<data>X1VQQw==</data>
<key>Limit</key>
<integer>0</integer>
<key>Mask</key>
<data></data>
<key>OemTableId</key>
<data>UHJvalNzZHQ=</data>
<key>Replace</key>
<data>WFVQQw==</data>
<key>ReplaceMask</key>
<data></data>
<key>Skip</key>
<integer>0</integer>
<key>TableLength</key>
<integer>6103</integer>
<key>TableSignature</key>
<data>U1NEVA==</data>
</dict> USBX can be merged with the EC device as SSDT-EC/USBX for consistency with the Dortania OpenCore guide. |
- Added ETPD (_CRS -> XCRS) ACPI rename
- Adds support for Sidecar, NightShift, Airplay to Mac, and Universal Control.
- Created for future supplemental documentation.
Removed all non-critical SSDTs (will need to test for UX581/UX582 in #7). |
- Removed AsusSMC ALS0 sensor - Removed EC renames for display brightness - Removed EC + notify methods for brightness keys TODO: Keyboard backlight - Removed keyboard backlight enable
- Added EC methods for FN+F4, FN+F5, FN+F7 keys - Added keyboard backlight control method - Added default keyboard backlight value
- Moved keyboard backlight methods to SSDT-KBLF - Simplified SSDT-EC-USBX logic (renamed) - Simplified SSDT-PLUG logic - Added trackpad GPIO pinning to SSDT-GPI0 - Added SSDT-SMBUS-MCHC TODO: - Add missing ATKD functions (e.g. FN Lock) - Add missing internal USB personalities (DCAM/DCAN, etc) - Add custom keyboard scan map
Thank, I'll see when I work at night :) but it will save a few MICRO seconds in the MacOS boot since it doesn't have to check this... In that's great (Micro seconds : in its pure state, it is really 0,00001 and still...) |
- Added Injector kext for Big Sur and Catalina - Added AirportItlwm kext for Big Sur and Catalina
Unclear what these ADB codes are (from SSDT-KBD): "Custom PS2 Map",
Package (0x06)
{
Package (0x00){},
"46=80", // 0x006b, Scroll Lock
"e045=80", // 0x0071, Pause
"e037=64", // 0x0000, Print Screen
"e052=67", // 0x0000, Insert
"e05d=57" // 0x0a00, App (context menu key)
}, |
Will revisit pending commits from @wern-apfel/Zenbook-UX481FA in a separate PR. Remaining issues will have to be solved in separate PRs:
|
Still need to test on different macOS versions (Catalina, Big Sur, Monterey <12.3) before merge. |
- Default setting for screenpad on boot is 0x64 - Start _Q31 method at 0xFF then move down to 0x64, 0x32, 0x14, Zero.
- Display not detected in settings using 05 (wrong busID value)
Added App Store URLs: - Ventura: https://apps.apple.com/us/app/macos-ventura/id1638787999 - Monterey: https://apps.apple.com/us/app/macos-monterey/id1576738294 - Big Sur: https://apps.apple.com/us/app/macos-big-sur/id1526878132 - Catalina: https://apps.apple.com/sg/app/macos-catalina/id1466841314
- Added min version and min date values for APFS - Refer to https://dortania.github.io/OpenCore-Install-Guide/config-laptop.plist/coffee-lake-plus.html#apfs
- Updated README with min build for MacbookPro16,3 - Refer to https://dortania.github.io/OpenCore-Install-Guide/config.plist/security.html#security-securebootmodel.
Current tasks:
- Backlight
_QD5
EC event._Q32
or 'toggle screenpad' key)._Q31
or 'switch displays' key).Housekeeping:
SSDT-UX481FA.aml
to essential SSDTs:SSDT-AWAK.aml
SSDT-EC-USBX.aml
SSDT-USBX(handled by SSDT-USB)SSDT-PLUG.aml
(required for macOS <12.3)SSDT-PNLF.aml
SSDT-GPIO.aml
orSSDT-XOSI.aml
CpuTscSync.kext
— fixes kernel panics on wakeDiskArbitrationFixup.kext
— userspace; hides unreadable disk message on bootECEnabler.kext
— addresses EC read byte lengthHibernationFixup.kext
— resolves hibernation issues w/ RTC + NVRAM