Generalizing Closeness centrality to weighted networks using Newman method

[FedericoBruzzone]

Close #1384

• I ran rustfmt locally
• I have added the tests to cover my changes.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.

[CLAassistant]

All committers have signed the CLA.

[IvanIsCoding]

THe implemenation LGTM for rustworkx-core, do you intend to make the method available for Pytohn users though?

I left a comment about the tests. It applies to all of our centrality metrics, we need to be careful with floats

[FedericoBruzzone]

THe implemenation LGTM for rustworkx-core, do you intend to make the method available for Pytohn users though?

I left a comment about the tests. It applies to all of our centrality metrics, we need to be careful with floats

Thanks for the review. I do not actually need the python implementation, but I can understand that this could improve usability for Python users. So, I will work on exposing the method to Python as well.

Regarding the tests, I appreciate the feedback. I'll make sure to add checks that account for floating-point precision issues across all centrality metrics.

[FedericoBruzzone]

@IvanIsCoding Make sure that the following commit is in line with the rest, but most importantly, make sure it is correct. Make available weighted_closeness for python users

Why is CI not starting? 🤔

[IvanIsCoding]

I need to manually approve CI.

Also, I asked about Python just to confirm. Someone else can work on the Python bindings.

[FedericoBruzzone]

I need to manually approve CI.

Also, I asked about Python just to confirm. Someone else can work on the Python bindings.

There was no problem to implement it. It was a pleasure, I look forward to your review :D

[coveralls]

Pull Request Test Coverage Report for Build 13320423785

Details

• 4 of 108 (3.7%) changed or added relevant lines in 3 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage decreased (-0.5%) to 95.313%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
rustworkx-core/src/centrality.rs	0	48	0.0%
src/centrality.rs	0	56	0.0%

Totals
Change from base Build 13300446603:	-0.5%
Covered Lines:	18425
Relevant Lines:	19331

---

💛 - Coveralls

[IvanIsCoding]

Just some minor details.

Also, let me know if you want to work on Python tests & the release note. I can do it if you want to focus on the rustworkx-core core. Adding support for Python are additional extra steps that can be delegated to a separate PR

[FedericoBruzzone]

Adding support for Python are additional extra steps that can be delegated to a separate PR

What are the additional steps beyond those made in this PR? Are they documented anywhere? I did not see them in the CONTRIBUTING file. This should be my task and I would like to do it 😄

let me know if you want to work on Python tests & the release note

If you can do that it is better, I will as soon as I can maybe implement the betweeness or the other method for closeness. Just out of curiosity, is it documented anywhere how to do release notes?

[IvanIsCoding]

The additional steps are compared to the work of adding just Rust code vs adding Python support. For Python:

• we need to add Python bindings, this is complete
• we need to add tests, which is TBD
• we need to add type annotations, which is almost there
• we need to add release notes, which is fairly simple, just run this inside the folder

pip install -U reno
reno new short-description-string

Because we have Rust tests, I am ok with merging the PR without Python tests and adding them later.

[IvanIsCoding]

Set up the weight_fn to be None by default to agree with the type annotations and we should be good to go. Also, default_weight=1.0 makes the function behave like the unweighted version when no weight function is passed

[FedericoBruzzone]

We should be good to go 😄

[IvanIsCoding]

This is good to go

[FedericoBruzzone]

This is good to go

I hope to find more time to do more PRs. Thanks for the review!