Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Y-eigenstate convention in SparsePauliOp.as_paulis #13847

Merged
merged 1 commit into from
Feb 14, 2025
Merged

Fix Y-eigenstate convention in SparsePauliOp.as_paulis #13847

merged 1 commit into from
Feb 14, 2025
+8 −8

Conversation

jakelishman
Copy link
Member

|r> is the positive eigenstate of Y, not the negative one. The tests also asserted this backwards.

Summary

Details and comments

No reno because the bug isn't released yet.

@jakelishman jakelishman added mod: quantum info Related to the Quantum Info module (States & Operators) Changelog: None Do not include in changelog Rust This PR or issue is related to Rust code in the repository labels Feb 14, 2025
@jakelishman jakelishman added this to the 2.0.0 milestone Feb 14, 2025
@jakelishman jakelishman requested a review from a team as a code owner February 14, 2025 17:31
@qiskit-bot
Copy link
Collaborator

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core

@jakelishman
Fix Y-eigenstate convention in SparsePauliOp.as_paulis
4e69702 
`|r>` is the positive eigenstate of Y, not the negative one.  The tests
also asserted this backwards.
@jakelishman jakelishman force-pushed the sparse-observable/fix-as-paulis branch from f039f93 to 4e69702 Compare February 14, 2025 17:54
@jakelishman
Copy link
Member Author

I see now that this duplicates some work from #13836, but since I need it in #13766 as well and both those two PRs are large, seems cleaner to split the bugfix off into a separate patch.

Cryoris
Cryoris approved these changes Feb 14, 2025
View reviewed changes
Copy link
Contributor

@Cryoris Cryoris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Cryoris Cryoris enabled auto-merge February 14, 2025 18:07
@coveralls
Copy link

Pull Request Test Coverage Report for Build 13334644728

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 7 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.01%) to 88.256%
Files with Coverage Reduction New Missed Lines %
crates/accelerate/src/unitary_synthesis.rs 3 93.29%
crates/qasm2/src/lex.rs 4 92.23%
Totals Coverage Status
Change from base Build 13332287685: 0.01%
Covered Lines: 78719
Relevant Lines: 89194
💛 - Coveralls

@Cryoris Cryoris added this pull request to the merge queue Feb 14, 2025
Merged via the queue into Qiskit:main with commit 581dd3d Feb 14, 2025
17 checks passed
@jakelishman jakelishman deleted the sparse-observable/fix-as-paulis branch February 14, 2025 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cryoris Cryoris Cryoris approved these changes

Assignees

@jakelishman jakelishman

@Cryoris Cryoris

Labels
Changelog: None Do not include in changelog mod: quantum info Related to the Quantum Info module (States & Operators) Rust This PR or issue is related to Rust code in the repository
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@jakelishman @qiskit-bot @coveralls @Cryoris