GenericBackendV2 should fail when the backend cannot allocate the basis gate because its size #12653

1ucian0 · 2024-06-25T08:50:53Z

Summary

GenericBackendV2 should not accept backends that are too small for certain gates. The following examples should be rejected:

GenericBackendV2(num_qubits=1, basis_gates=["cx", "id"])

GenericBackendV2(num_qubits=2, basis_gates=["ccx", "id"])

@ElePT found this!

…is gate because its size Co-authored-by: Elena Peña Tapia <[email protected]>

qiskit-bot · 2024-06-25T08:50:57Z

One or more of the following people are relevant to this code:

@Qiskit/terra-core

coveralls · 2024-06-25T09:16:41Z

Pull Request Test Coverage Report for Build 9659396940

Details

2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
23 unchanged lines in 3 files lost coverage.
Overall coverage decreased (-0.03%) to 89.729%

Files with Coverage Reduction	New Missed Lines	%
crates/qasm2/src/expr.rs	1	94.02%
crates/qasm2/src/lex.rs	4	92.62%
crates/qasm2/src/parse.rs	18	96.69%

Totals
Change from base Build 9650973845:	-0.03%
Covered Lines:	63758
Relevant Lines:	71056

💛 - Coveralls

ElePT

thanks @1ucian0 LGTM, I left a small reno suggestion (am I allowed to approve?)

releasenotes/notes/fixes_GenericBackendV2-668e40596e1f070d.yaml

coveralls · 2024-06-25T14:05:48Z

Pull Request Test Coverage Report for Build 9663589789

Details

2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
7 unchanged lines in 2 files lost coverage.
Overall coverage increased (+0.01%) to 89.732%

Files with Coverage Reduction	New Missed Lines	%
crates/qasm2/src/expr.rs	1	94.02%
crates/qasm2/src/lex.rs	6	91.6%

Totals
Change from base Build 9661630219:	0.01%
Covered Lines:	63760
Relevant Lines:	71056

💛 - Coveralls

Co-authored-by: Elena Peña Tapia <[email protected]>

1ucian0 · 2024-06-25T14:07:20Z

am I allowed to approve?

It seems you are.

coveralls · 2024-06-25T14:31:49Z

Pull Request Test Coverage Report for Build 9663987131

Details

2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
5 unchanged lines in 2 files lost coverage.
Overall coverage increased (+0.01%) to 89.731%

Files with Coverage Reduction	New Missed Lines	%
crates/qasm2/src/expr.rs	1	94.02%
crates/qasm2/src/lex.rs	4	92.37%

Totals
Change from base Build 9661630219:	0.01%
Covered Lines:	63759
Relevant Lines:	71056

💛 - Coveralls

ElePT · 2024-06-25T16:51:11Z

I think we need to add an internal path for building a target for 1 qubit, because GenericBackendV2 contains 2q basis gates by default (that's why the test fails currently).

coveralls · 2024-06-25T18:44:36Z

Pull Request Test Coverage Report for Build 9667579174

Details

2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
6 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.03%) to 89.748%

Files with Coverage Reduction	New Missed Lines	%
crates/qasm2/src/lex.rs	6	92.62%

Totals
Change from base Build 9661630219:	0.03%
Covered Lines:	63771
Relevant Lines:	71056

💛 - Coveralls

1ucian0 · 2024-06-25T19:12:31Z

I think we need to add an internal path for building a target for 1 qubit, because GenericBackendV2 contains 2q basis gates by default (that's why the test fails currently).

I think I prefer to keep the default simple (without different values depending on the number of qubits) and be explicit on the basis _gate (see 43a94f1). What do you think?

ElePT · 2024-06-26T07:41:01Z

I think that can work too. If we see this is causing problems we can always correct the 1q path.

1ucian0 · 2024-06-26T08:37:31Z

@Mergifyio backport stable/0.46 stable/1.1

mergify · 2024-06-26T08:37:41Z

backport stable/0.46 stable/1.1

✅ Backports have been created

#12666 GenericBackendV2 should fail when the backend cannot allocate the basis gate because its size (backport #12653) has been created for branch stable/0.46 but encountered conflicts
#12667 GenericBackendV2 should fail when the backend cannot allocate the basis gate because its size (backport #12653) has been created for branch stable/1.1

…is gate because its size (#12653) * GenericBackendV2 should fail when the backend cannot allocate the basis gate because its size Co-authored-by: Elena Peña Tapia <[email protected]> * reno * Update releasenotes/notes/fixes_GenericBackendV2-668e40596e1f070d.yaml Co-authored-by: Elena Peña Tapia <[email protected]> * another single qubit backend --------- Co-authored-by: Elena Peña Tapia <[email protected]> (cherry picked from commit e36027c)

…is gate because its size (#12653) * GenericBackendV2 should fail when the backend cannot allocate the basis gate because its size Co-authored-by: Elena Peña Tapia <[email protected]> * reno * Update releasenotes/notes/fixes_GenericBackendV2-668e40596e1f070d.yaml Co-authored-by: Elena Peña Tapia <[email protected]> * another single qubit backend --------- Co-authored-by: Elena Peña Tapia <[email protected]> (cherry picked from commit e36027c) # Conflicts: # qiskit/providers/fake_provider/generic_backend_v2.py # test/visual/mpl/graph/test_graph_matplotlib_drawer.py

…is gate because its size (#12653) (#12667) * GenericBackendV2 should fail when the backend cannot allocate the basis gate because its size Co-authored-by: Elena Peña Tapia <[email protected]> * reno * Update releasenotes/notes/fixes_GenericBackendV2-668e40596e1f070d.yaml Co-authored-by: Elena Peña Tapia <[email protected]> * another single qubit backend --------- Co-authored-by: Elena Peña Tapia <[email protected]> (cherry picked from commit e36027c) Co-authored-by: Luciano Bello <[email protected]>

…is gate because its size (backport #12653) (#12666) * GenericBackendV2 should fail when the backend cannot allocate the basis gate because its size (#12653) * GenericBackendV2 should fail when the backend cannot allocate the basis gate because its size Co-authored-by: Elena Peña Tapia <[email protected]> * reno * Update releasenotes/notes/fixes_GenericBackendV2-668e40596e1f070d.yaml Co-authored-by: Elena Peña Tapia <[email protected]> * another single qubit backend --------- Co-authored-by: Elena Peña Tapia <[email protected]> (cherry picked from commit e36027c) # Conflicts: # qiskit/providers/fake_provider/generic_backend_v2.py # test/visual/mpl/graph/test_graph_matplotlib_drawer.py * Fix Conflict * Update test_graph_matplotlib_drawer.py * black --------- Co-authored-by: Luciano Bello <[email protected]> Co-authored-by: Elena Peña Tapia <[email protected]>

…is gate because its size (Qiskit#12653) * GenericBackendV2 should fail when the backend cannot allocate the basis gate because its size Co-authored-by: Elena Peña Tapia <[email protected]> * reno * Update releasenotes/notes/fixes_GenericBackendV2-668e40596e1f070d.yaml Co-authored-by: Elena Peña Tapia <[email protected]> * another single qubit backend --------- Co-authored-by: Elena Peña Tapia <[email protected]>

1ucian0 and others added 2 commits June 25, 2024 10:45

GenericBackendV2 should fail when the backend cannot allocate the bas…

8bcdcbb

…is gate because its size Co-authored-by: Elena Peña Tapia <[email protected]>

reno

493dc84

1ucian0 requested review from jyu00 and a team as code owners June 25, 2024 08:50

1ucian0 added the Changelog: Bugfix Include in the "Fixed" section of the changelog label Jun 25, 2024

Merge branch 'main' into fixes/GenericBackendV2/1

9913044

ElePT previously approved these changes Jun 25, 2024

View reviewed changes

releasenotes/notes/fixes_GenericBackendV2-668e40596e1f070d.yaml Outdated Show resolved Hide resolved

1ucian0 dismissed ElePT’s stale review via c8982a7 June 25, 2024 14:06

Update releasenotes/notes/fixes_GenericBackendV2-668e40596e1f070d.yaml

c8982a7

Co-authored-by: Elena Peña Tapia <[email protected]>

ElePT previously approved these changes Jun 25, 2024

View reviewed changes

ElePT enabled auto-merge June 25, 2024 14:06

another single qubit backend

43a94f1

1ucian0 dismissed ElePT’s stale review via 43a94f1 June 25, 2024 18:16

ElePT approved these changes Jun 26, 2024

View reviewed changes

ElePT added this pull request to the merge queue Jun 26, 2024

Merged via the queue into Qiskit:main with commit e36027c Jun 26, 2024
15 checks passed

This was referenced Jun 26, 2024

GenericBackendV2 should fail when the backend cannot allocate the basis gate because its size (backport #12653) #12666

Merged

GenericBackendV2 should fail when the backend cannot allocate the basis gate because its size (backport #12653) #12667

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GenericBackendV2 should fail when the backend cannot allocate the basis gate because its size #12653

GenericBackendV2 should fail when the backend cannot allocate the basis gate because its size #12653

1ucian0 commented Jun 25, 2024

qiskit-bot commented Jun 25, 2024

coveralls commented Jun 25, 2024 •

edited

Loading

ElePT left a comment

coveralls commented Jun 25, 2024 •

edited

Loading

1ucian0 commented Jun 25, 2024

coveralls commented Jun 25, 2024 •

edited

Loading

ElePT commented Jun 25, 2024

coveralls commented Jun 25, 2024 •

edited

Loading

1ucian0 commented Jun 25, 2024

ElePT commented Jun 26, 2024

1ucian0 commented Jun 26, 2024

mergify bot commented Jun 26, 2024 •

edited

Loading

GenericBackendV2 should fail when the backend cannot allocate the basis gate because its size #12653

GenericBackendV2 should fail when the backend cannot allocate the basis gate because its size #12653

Conversation

1ucian0 commented Jun 25, 2024

Summary

qiskit-bot commented Jun 25, 2024

coveralls commented Jun 25, 2024 • edited Loading

Pull Request Test Coverage Report for Build 9659396940

Details

💛 - Coveralls

ElePT left a comment

Choose a reason for hiding this comment

coveralls commented Jun 25, 2024 • edited Loading

Pull Request Test Coverage Report for Build 9663589789

Details

💛 - Coveralls

1ucian0 commented Jun 25, 2024

coveralls commented Jun 25, 2024 • edited Loading

Pull Request Test Coverage Report for Build 9663987131

Details

💛 - Coveralls

ElePT commented Jun 25, 2024

coveralls commented Jun 25, 2024 • edited Loading

Pull Request Test Coverage Report for Build 9667579174

Details

💛 - Coveralls

1ucian0 commented Jun 25, 2024

ElePT commented Jun 26, 2024

1ucian0 commented Jun 26, 2024

mergify bot commented Jun 26, 2024 • edited Loading

✅ Backports have been created

coveralls commented Jun 25, 2024 •

edited

Loading

coveralls commented Jun 25, 2024 •

edited

Loading

coveralls commented Jun 25, 2024 •

edited

Loading

coveralls commented Jun 25, 2024 •

edited

Loading

mergify bot commented Jun 26, 2024 •

edited

Loading