Fix missing layout in Commuting2qGateRouter (backport #12137)
#12383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
* Add layout to property set, add test * Apply comments from code review * Add virtual permutation instead of final layout. Test (cherry picked from commit b80885d)
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
github-actions
bot
added
the
Changelog: Bugfix
jakelishman
approved these changes
May 9, 2024
Pull Request Test Coverage Report for Build 9023915733Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an oversight in the
Commuting2qGateRouterpass where the qreg permutations weren't tracked in the property set, the output circuitlayoutwould be missing, and uses would have to keep track of the mapping from cregs to qregs manually.Details and comments
Found while working on a PR that used this pass in an independent repository: qiskit-community/qopt-best-practices#30.
This is an automatic backport of pull request #12137 done by [Mergify](https://mergify.com).