Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in document qiskit.transpiler.preset_passmanagers.generate_preset_pass_manager. #11983

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

yoshida-ryuhei
Copy link
Contributor

  • I have added the tests to cover my changes.
    • no need
  • I have updated the documentation accordingly.
  • no need
  • I have read the CONTRIBUTING document.

Summary

Fix a minor typo in the document for the qiskit.transpiler.preset_passmanagers.generate_preset_pass_manager.

Details and comments

The link in the document of qiskit.transpiler.preset_passmanagers.generate_preset_pass_manager is partially broken.
For the descriptions of layout_method in the parameters, the method DenseLayout has no link, as other methods have links.

This PR fixes the link.

@yoshida-ryuhei yoshida-ryuhei requested a review from a team as a code owner March 11, 2024 05:40
@qiskit-bot qiskit-bot added the Community PR PRs from contributors that are not 'members' of the Qiskit repo label Mar 11, 2024
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8228212457

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 33 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.04%) to 89.283%

Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/expr.rs 1 93.81%
crates/qasm2/src/lex.rs 8 90.93%
crates/qasm2/src/parse.rs 24 96.23%
Totals Coverage Status
Change from base Build 8190588005: -0.04%
Covered Lines: 59124
Relevant Lines: 66221

💛 - Coveralls

@yoshida-ryuhei yoshida-ryuhei changed the title Fix typo Fix typo in document qiskit.transpiler.preset_passmanagers.generate_preset_pass_manager. Mar 11, 2024
Copy link
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for catching and fixing this.

@mtreinish mtreinish added documentation Something is not clear or an error documentation stable backport potential The bug might be minimal and/or import enough to be port to stable Changelog: None Do not include in changelog labels Mar 11, 2024
@mtreinish mtreinish enabled auto-merge March 11, 2024 07:06
@mtreinish mtreinish added this pull request to the merge queue Mar 11, 2024
Merged via the queue into Qiskit:main with commit 9f228fa Mar 11, 2024
12 checks passed
mergify bot pushed a commit that referenced this pull request Mar 11, 2024
(cherry picked from commit 9f228fa)
github-merge-queue bot pushed a commit that referenced this pull request Mar 11, 2024
(cherry picked from commit 9f228fa)

Co-authored-by: Ryuhei Yoshida <[email protected]>
@yoshida-ryuhei yoshida-ryuhei deleted the fix_typo branch March 13, 2024 04:50
IsmaelCesar pushed a commit to comp-quantica/qiskit-terra that referenced this pull request Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: None Do not include in changelog Community PR PRs from contributors that are not 'members' of the Qiskit repo documentation Something is not clear or an error documentation stable backport potential The bug might be minimal and/or import enough to be port to stable
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants