Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

use optional wait to change polling rate #765

Merged
merged 2 commits into from
Nov 15, 2023
Merged

Conversation

splch
Copy link
Contributor

@splch splch commented Nov 9, 2023

Summary

uses an optional wait argument like JobV1 to change the polling time for the wait_for_final_state method.

Details and comments

defaults to 3 seconds for backwards compatibility

Copy link
Member

@kt474 kt474 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @splch! LGTM

The build is failing due to a separate issue which i'll take care of in a separate PR

@kt474 kt474 merged commit bb6adfe into Qiskit:main Nov 15, 2023
Copy link

Pull Request Test Coverage Report for Build 6883369034

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on wait-final-state at 51.713%

Totals Coverage Status
Change from base Build 6883353494: 51.7%
Covered Lines: 3411
Relevant Lines: 6596

💛 - Coveralls

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants