Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding some new events #80

Closed
wants to merge 6 commits into from
Closed

Adding some new events #80

wants to merge 6 commits into from

Conversation

1Evolve
Copy link

@1Evolve 1Evolve commented Jan 26, 2024

Description

  1. When activated, this event checks the bank account of the nearest layer and sends the data to the server
  2. When activated, this event checks the licenses of the nearest player and sends the data to the server

Please note that these events are designed to be part of the in-game police scenario, enabling them to perform actions such as checking bank accounts, licenses, and seizing driver's licenses effectively.

At another time, some events will be

  1. added, such as: Check whether the player has unpaid bills
  2. The player's mask is removed by the policeman

Checklist

  • I have personally loaded this code into an updated Qbox project and checked all of its functionality.
  • My pull request fits the contribution guidelines & code conventions.

1. When activated, this event checks the bank account of the nearest layer and sends the data to the server
2. When activated, this event checks the licenses of the nearest player and sends the data to the server
3. When activated, this event seizes the driver's license of the nearest player and sends the data to the server.

Please note that these events are designed to be part of the in-game police scenario, enabling them to perform actions such as checking bank accounts, licenses, and seizing driver's licenses effectively.


At another time, some events will be
1. added, such as: Check whether the player has unpaid bills
2. The player's mask is removed by the policeman
Copy link
Contributor

@Manason Manason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you address more details of this proposed set of features? How would users interact with other players? Command? Radial menu? 3rd eye?

I'm curious as to what other people think of these proposed features, but at the very least I would want them gated behind config option to enable them (default disabled).

To address the actual code structure, I'm not seeing a need/use for the client event handlers. It seems like the server has all the information needed already.

@1Evolve
Copy link
Author

1Evolve commented Jan 26, 2024

Could you address more details of this proposed set of features? How would users interact with other players? Command? Radial menu? 3rd eye?

I'm curious as to what other people think of these proposed features, but at the very least I would want them gated behind config option to enable them (default disabled).

To address the actual code structure, I'm not seeing a need/use for the client event handlers. It seems like the server has all the information needed already.

When approved, it will be added to radial menu

@1Evolve
Copy link
Author

1Evolve commented Jan 27, 2024

@mafewtm
Copy link
Member

mafewtm commented Jan 27, 2024

I don't think police being able to check peoples bank accounts is a feature that should be added nor should it be a radial menu option either. And for the seizing of licenses, this is already available through the revocation of licenses.

@TonybynMp4
Copy link
Contributor

+1 on what matthew said + let's stop doing things on the 'closest' player, we can target a specific player, just use that..

@1Evolve 1Evolve closed this Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants