Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes to derive Asset base from the Asset identifier #7

Merged
merged 3 commits into from
Apr 18, 2023
Merged

Changes to derive Asset base from the Asset identifier #7

merged 3 commits into from
Apr 18, 2023

Conversation

vivek-arte
Copy link

@vivek-arte vivek-arte commented Mar 21, 2023 •
edited
Loading

This adds the changes to the zcash test vectors to update the calculation of the Asset Base from the Asset Identifier via the Asset Digest, as detailed in ZIP 227.

PaulLaux
PaulLaux previously approved these changes Mar 29, 2023
View reviewed changes
Copy link

@PaulLaux PaulLaux left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, approved pending comments.

In addition, add a proper description to the PR.

When merging, make sure to copy the updated PR description to the merge comment box. This is done to have a proper git commit msg.

@vivek-arte vivek-arte merged commit 4cf6062 into zsa1 Apr 18, 2023
@vivek-arte vivek-arte mentioned this pull request Apr 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PaulLaux PaulLaux PaulLaux left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vivek-arte @PaulLaux