Address PR #100 review notes (some issues remain unresolved) #1278
Clippy (Stable ~ Linux/x86_64)
Clippy was successful!
Details
Running cargo clippy took roughly ~20668ms to complete
- Working Directory: repository directory
Annotations
Check warning on line 6 in /home/runner/work/orchard/orchard/src/lib.rs
github-actions / Clippy Result (stable)
/home/runner/work/orchard/orchard/src/lib.rs#L6
unused import: `H`
Raw output
warning: unused import: `H`
--> src/constants.rs:6:91
|
6 | pub use fixed_bases::{NullifierK, OrchardFixedBases, OrchardFixedBasesFull, ValueCommitV, H};
| ^
|
= note: `#[warn(unused_imports)]` on by default
Check warning on line 270 in /home/runner/work/orchard/orchard/src/lib.rs
github-actions / Clippy Result (stable)
/home/runner/work/orchard/orchard/src/lib.rs#L270
use of a fallible conversion when an infallible one could be used
Raw output
warning: use of a fallible conversion when an infallible one could be used
--> src/keys.rs:270:27
|
270 | self.0.to_bytes().try_into().unwrap()
| ^^^^^^^^^^^^^^^^^^^
|
= note: converting `GenericArray<u8, UInt<UInt<UInt<UInt<UInt<UInt<UTerm, B1>, B0>, B0>, B0>, B0>, B0>>` to `[u8; 32]` cannot fail
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions
= note: `#[warn(clippy::unnecessary_fallible_conversions)]` on by default
help: use
|
270 - self.0.to_bytes().try_into().unwrap()
270 + self.0.to_bytes().into()
|
Check warning on line 337 in /home/runner/work/orchard/orchard/src/lib.rs
github-actions / Clippy Result (stable)
/home/runner/work/orchard/orchard/src/lib.rs#L337
use of a fallible conversion when an infallible one could be used
Raw output
warning: use of a fallible conversion when an infallible one could be used
--> src/keys.rs:337:27
|
337 | self.0.to_bytes().try_into().unwrap()
| ^^^^^^^^^^^^^^^^^^^
|
= note: converting `GenericArray<u8, UInt<UInt<UInt<UInt<UInt<UInt<UTerm, B1>, B0>, B0>, B0>, B0>, B0>>` to `[u8; 32]` cannot fail
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions
help: use
|
337 - self.0.to_bytes().try_into().unwrap()
337 + self.0.to_bytes().into()
|
Check warning on line 0 in ./file/that/probably/doesnt/exist.rs
github-actions / Clippy Result (stable)
./file/that/probably/doesnt/exist.rs#L0
4 warnings emitted
Raw output
warning: 4 warnings emitted