error[E0432]: unresolved import `orchard::orchard_flavor` --> benches/circuit.rs:15:5 | 15 | orchard_flavor::OrchardZSA, | ^^^^^^^^^^^^^^ could not find `orchard_flavor` in `orchard`

unresolved import `orchard::orchard_flavor`: benches/note_decryption.rs#L9

error[E0432]: unresolved import `orchard::orchard_flavor` --> benches/note_decryption.rs:9:5 | 9 | orchard_flavor::OrchardZSA, | ^^^^^^^^^^^^^^ could not find `orchard_flavor` in `orchard`

Bitrot check: benches/note_decryption.rs#L9

unresolved import `orchard::orchard_flavor`

Bitrot check: benches/circuit.rs#L15

unresolved import `orchard::orchard_flavor`

Bitrot check

could not compile `orchard` due to previous error

Bitrot check

The process '/home/runner/.cargo/bin/cargo' failed with exit code 101

Book tests

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2, actions-rs/toolchain@v1, peaceiris/actions-mdbook@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Book tests

The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

Book tests

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Book tests

Rustfmt

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Rustfmt

The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

Rustfmt

use of `default` to create a unit struct: src/note/commitment.rs#L164

warning: use of `default` to create a unit struct --> src/note/commitment.rs:164:31 | 164 | let mut os_rng = OsRng::default(); | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs = note: `#[warn(clippy::default_constructed_unit_structs)]` on by default

use of a fallible conversion when an infallible one could be used: src/keys.rs#L330

warning: use of a fallible conversion when an infallible one could be used --> src/keys.rs:330:27 | 330 | self.0.to_bytes().try_into().unwrap() | ^^^^^^^^^^^^^^^^^^^ | = note: converting `GenericArray<u8, UInt<UInt<UInt<UInt<UInt<UInt<UTerm, B1>, B0>, B0>, B0>, B0>, B0>>` to `[u8; 32]` cannot fail = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions help: use | 330 - self.0.to_bytes().try_into().unwrap() 330 + self.0.to_bytes().into() |

use of a fallible conversion when an infallible one could be used: src/keys.rs#L263

warning: use of a fallible conversion when an infallible one could be used --> src/keys.rs:263:27 | 263 | self.0.to_bytes().try_into().unwrap() | ^^^^^^^^^^^^^^^^^^^ | = note: converting `GenericArray<u8, UInt<UInt<UInt<UInt<UInt<UInt<UTerm, B1>, B0>, B0>, B0>, B0>, B0>>` to `[u8; 32]` cannot fail = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions = note: `#[warn(clippy::unnecessary_fallible_conversions)]` on by default help: use | 263 - self.0.to_bytes().try_into().unwrap() 263 + self.0.to_bytes().into() |

accessing first element with `notes.get(0)`: tests/zsa.rs#L172

warning: accessing first element with `notes.get(0)` --> tests/zsa.rs:172:17 | 172 | let note1 = notes.get(0).unwrap(); | ^^^^^^^^^^^^ help: try: `notes.first()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first = note: `#[warn(clippy::get_first)]` on by default

use of a fallible conversion when an infallible one could be used: src/keys.rs#L330

use of a fallible conversion when an infallible one could be used: src/keys.rs#L263

unused import: `H`: src/constants.rs#L6

warning: unused import: `H` --> src/constants.rs:6:91 | 6 | pub use fixed_bases::{NullifierK, OrchardFixedBases, OrchardFixedBasesFull, ValueCommitV, H}; | ^ | = note: `#[warn(unused_imports)]` on by default

unused import: `H`: src/constants.rs#L6