Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed footer size in mobile #422

Closed
wants to merge 5 commits into from
Closed

Conversation

nik464
Copy link
Contributor

@nik464 nik464 commented Jul 25, 2021

Fixes #(issue number)

#404

Describe the changes you've made

I have changed size of the footer in mobile. As screen reduces size from 992 px, footer height becomes 40 px instead of 80 px.

Describe if there is any unusual behaviour of your code(Write NA if there isn't)

No there is no unusual behaviour

Deploy your changes to github page or netlify and mention deployment link:

Add the deployment link here.

Additional context (OPTIONAL)

Add any other context or screenshots about the feature request here.

Test plan (OPTIONAL)

You can check index. html and change the size of the page by inspect element.

Checklist

  • I have mentioned related issue number in PR description.
  • I have added screenshots and related demo links of my changes..
  • The title of my pull request is a short description of the requested changes.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • Open Source Program names(OPTIONAL: If you participated in any open-source program then please mention the program name here)

@QAZIMAAZARSHAD
Copy link
Owner

Host your website and share the website link so I can review your changes.

@nik464
Copy link
Contributor Author

nik464 commented Jul 25, 2021

https://hardcore-bell-2341cc.netlify.app/

For less then 992, that is small screen footer becomes half.

@QAZIMAAZARSHAD
Copy link
Owner

Fetch upstream your repo is 26 commits behind.

@QAZIMAAZARSHAD
Copy link
Owner

And nothing has changed.
It is similar.

Check
image

@QAZIMAAZARSHAD
Copy link
Owner

Size of footer is same.

@QAZIMAAZARSHAD
Copy link
Owner

After the changes check every single page.

Then only make PR.

@nik464
Copy link
Contributor Author

nik464 commented Jul 25, 2021

ok is it not working for index.html? I will surely make changes in all pages . Actually i thought only black footer in index.html has to be made small.

@QAZIMAAZARSHAD
Copy link
Owner

No need to change the footer of the index page. That's perfectly fine.

The problem is with other pages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants