-
-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed footer size in mobile #422
Conversation
changed toggle towards bottom left
changed text
Host your website and share the website link so I can review your changes. |
https://hardcore-bell-2341cc.netlify.app/ For less then 992, that is small screen footer becomes half. |
Fetch upstream your repo is 26 commits behind. |
Size of footer is same. |
After the changes check every single page. Then only make PR. |
ok is it not working for index.html? I will surely make changes in all pages . Actually i thought only black footer in index.html has to be made small. |
No need to change the footer of the index page. That's perfectly fine. The problem is with other pages. |
Fixes #(issue number)
#404
Describe the changes you've made
I have changed size of the footer in mobile. As screen reduces size from 992 px, footer height becomes 40 px instead of 80 px.
Describe if there is any unusual behaviour of your code(Write
NA
if there isn't)No there is no unusual behaviour
Deploy your changes to github page or netlify and mention deployment link:
Add the deployment link here.
Additional context (OPTIONAL)
Add any other context or screenshots about the feature request here.
Test plan (OPTIONAL)
You can check index. html and change the size of the page by inspect element.
Checklist