-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import and change appropriately the pyramid docs regards paste.translogg... #70
Conversation
The index.rst path maybe needs to be reworked so that it doesn't try to explain both logging config and middleware config at once. I'd suggest something like this structure:
|
I'm trying to rewrite this PR. @mcdonc It looks like paste.translogger had some work on py3 compatibility. Is an apology still needed? Also are you suggesting that the two sections "Logging" and @kpinc's "Web Traffic Logging With Paste's TransLogging Middleware" both be combined into a single section "Access Logging" with four subsections, or something else? |
@stevepiercy or @kpinc are you still working on this? If not I will close out this PR. |
I am awaiting feedback from @mcdonc or whoever answers my questions for further direction. |
I am trying to understand what apology you are referring to. I think adding more information about logging would be great, but adding it to the current index.rst I don't think is a good idea. The docs in general need a good once over, clean them up, add appropriate sections, and make it flow better. Not sure if this is the right ticket or not. |
...because I see some recent work indicates it is available for py3. I'm not absolutely sure whether it is or not available for py3, but if it is available, then no apology is needed. For this ticket, I think you're right: it makes sense to break out logging from the index. I mean, an index page is supposed to be an index of content, not the content itself (unless of course it's a SPD or a Single Page Documentation). If there are other structural changes, I'd suggest creating a Task List in a new ticket. Bite size morsels are more easily consumed. - [ ] Task incomplete
- [x] Task complete
- [ ] ~~Task cancelled~~
|
@bertjwregeer to make progress on this ticket, how about we create a new branch off of |
Alternatively, let's merge this, then I can break out sections into separate pages in the docs? ping @bertjwregeer |
@stevepiercy do you want to champion this change still? |
@bertjwregeer yup. Created new branch under Pylons so I can do the necessary work there instead of here. |
Moved work under the branch |
Note that while the docs build fine I did not actually execute the code!