-
-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add possibility to start bot via async context manager #1801
feat: Add possibility to start bot via async context manager #1801
Conversation
Thanks for the pull request! |
999c22f
to
1b03207
Compare
If you need something, leme know ;) |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1801 +/- ##
==========================================
- Coverage 33.32% 33.32% -0.01%
==========================================
Files 97 97
Lines 18916 18927 +11
==========================================
+ Hits 6304 6307 +3
- Misses 12612 12620 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please resolve merge conflicts.
I did a rebase on master... but there were no conflicts. Not sure what you meant. |
Also, since this feature is done, it would be nice if you could remove the "in progress" label again ;) |
Any chance getting this merged? ;) |
This comment was marked as abuse.
This comment was marked as abuse.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a changelog entry for this
Could this be shown in the docs / basic examples? |
2f43a9c
to
a96dcbe
Compare
@BobDotCom changelog added |
e7e5f0c
to
a4b537d
Compare
Add basic example to start the bot with an async context manager. The example contains a `/hello` slash command which responds with a "Hellp @author".
9ee2b4f
to
2f7680f
Compare
for more information, see https://pre-commit.ci
Signed-off-by: Lala Sabathil <[email protected]>
Summary
This is a feature pull request. It allowes you to start the bot via an async context manager.
Till now you were able to subclass
Bot
with something likeNow you can also start the bot via an async context manager
Information
examples, ...).
Checklist
type: ignore
comments were used, a comment is also left explaining why.