Static type checking with PhantomData #41
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, this code
causes panic.
But, isn't it annoying to give a type annotation like
from_vec::<i64>
, and isn't it really user-friendly to cause panic?So, this PR introduces
PyArray<T>
instead ofPyArray
.By this change, when we write
, we can get compile error.
@termoshtt
This is a breaking change so I want to hear your opnion 🙂