Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add subclassing testcase which previously caused a segfault #721

Merged
merged 3 commits into from
Jan 12, 2020
Merged

Add subclassing testcase which previously caused a segfault #721

merged 3 commits into from
Jan 12, 2020

Conversation

Alexander-N
Copy link
Member

@Alexander-N Alexander-N commented Jan 11, 2020 •
edited
Loading

Add a testcase from #407. Both test cases don't segfault after the
change to the #[pyclass] system in #683.

Edit: Also remove unsound-subclass feature.

Closes #407, Closes #220

@Alexander-N
Add subclassing testcase which previously caused a segfault
3dc5b86 
Add a testcase from PyO3#407. Both test cases don't segfault after the
change to the #[pyclass] system in PyO3#683.

Closes PyO3#407
@Alexander-N
Revert "Disable segfaulty subclassing by default"
0a84c20 
This reverts commit 5096f93.
@Alexander-N
Update CHANGELOG.md
472fbf4
@kngwyu
Copy link
Member

kngwyu commented Jan 12, 2020

Thank you!

@kngwyu kngwyu merged commit 6bd6633 into PyO3:master Jan 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kngwyu kngwyu kngwyu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@Alexander-N @kngwyu