Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove intoPyObject #583

Merged
merged 2 commits into from
Aug 26, 2019
Merged

Remove intoPyObject #583

merged 2 commits into from
Aug 26, 2019

Conversation

konstin
Copy link
Member

@konstin konstin commented Aug 24, 2019

This replaces IntoPyObject with IntoPy<PyObject>, meaning one less conversion trait.

@konstin konstin force-pushed the remove-into-py-object branch from c06ae70 to b04727c Compare August 25, 2019 21:53
Copy link
Member

@kngwyu kngwyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kngwyu
Copy link
Member

kngwyu commented Aug 26, 2019

Thank you for this heavy PR.

@konstin konstin merged commit a4c9fb9 into master Aug 26, 2019
@konstin konstin deleted the remove-into-py-object branch August 26, 2019 14:35
@konstin konstin mentioned this pull request Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants