Make CI fail on clippy warnings #534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kngwyu
approved these changes
Jul 15, 2019
| @@ -221,7 +221,7 @@ where | |||
| // Behave like python's __getattr__ (as opposed to __getattribute__) and check | |||
| // for existing fields and methods first | |||
| let existing = ffi::PyObject_GenericGetAttr(slf, arg); | |||
| if existing == std::ptr::null_mut() { | |||
| if existing.is_null() { | |||
Codecov Report
@@ Coverage Diff @@
## master #534 +/- ##
==========================================
- Coverage 87.68% 87.56% -0.12%
==========================================
Files 65 65
Lines 3443 3443
==========================================
- Hits 3019 3015 -4
- Misses 424 428 +4
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #534 +/- ##
=======================================
Coverage 87.56% 87.56%
=======================================
Files 65 65
Lines 3443 3443
=======================================
Hits 3015 3015
Misses 428 428
Continue to review full report at Codecov.
|
konstin
reviewed
Jul 15, 2019
| @@ -234,6 +234,7 @@ impl<'p> Python<'p> { | |||
| } | |||
|
|
|||
| /// Register `ffi::PyObject` pointer in release pool | |||
| #[allow(clippy::wrong_self_convention)] | |||
There was a problem hiding this comment.
I'd like to eventually rename and and move those functions, but for now that's fine.
konstin
approved these changes
Jul 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix or ignore all current clippy warnings and let the CI fail if in the future if there are warnings.