-
Notifications
You must be signed in to change notification settings - Fork 792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Adds the Bound<'_, PyMappingProxy> type #4644
Changes from 11 commits
b2c4d76
8ae75b4
4bad990
a7126d0
b155ecd
fdee81a
878ed16
de9743f
b209d58
55de052
14aa10c
24304f9
e9a33ae
14a3751
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
New `PyMappingProxy` struct corresponing to the `mappingproxy` class in Python. |
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm open to considering the conversion changes in this file, but these changes might break existing users' code silently. I'm unsure both if it's worth the churn and also what the performance cost might be. If we move ahead with these we should also include the corresponding changes to the index map and hash brown conversions. At a minimum I would at like to see these changes split off into a separate PR, although I will be honest that there is a chance we might decide not to have these. Was it critical for your use case? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Went ahead and removed the conversion changes. It isn't necessary for me, I just had it in there because of the previous PR. |
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -780,7 +780,7 @@ where | |||||
} | ||||||
|
||||||
/// Represents a tuple which can be used as a PyDict item. | ||||||
trait PyDictItem<'py> { | ||||||
pub trait PyDictItem<'py> { | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This looks a possibly unintentional change
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Removed! For some reason I thought I needed this for one of the tests. |
||||||
type K: IntoPyObject<'py>; | ||||||
type V: IntoPyObject<'py>; | ||||||
fn unpack(self) -> (Self::K, Self::V); | ||||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This function doesn't exist in https://github.com/python/cpython/blob/3.13/Include/descrobject.h (indeed I couldn't find it anywhere). So we shouldn't add this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed!