ci: run coverage jobs in pull_request_target context
#4483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidhewitt
force-pushed
the
codecov-diff
branch
from
3616edb to
83be449
Compare
|
Need to merge this to see if it worked, because |
|
In general, |
davidhewitt
added a commit
that referenced
this pull request
Aug 24, 2024
This reverts commit 44c16ec.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the
coveragetask to a separate ci task which runs on thepull_request_targettrigger. This ensures that coverage runs against the original branch and compares to its base. The rest of our jobs run on the merge commit so pick up CI fixes from main, but codecov seems to get confused about how to calculate the merge base correctly so we get strange job failures.Replaces #4472