Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reintroduce Python::run and Python::eval #4435

Merged
merged 3 commits into from
Aug 15, 2024
Merged

Reintroduce Python::run and Python::eval #4435

merged 3 commits into from
Aug 15, 2024

Conversation

Icxolu
Copy link
Contributor

@Icxolu Icxolu commented Aug 12, 2024

Should we also change code to a &CStr for both of these?

@Icxolu Icxolu added the CI-skip-changelog Skip checking changelog entry label Aug 12, 2024
@davidhewitt
Copy link
Member

davidhewitt commented Aug 12, 2024 •
edited
Loading

I think a &CStr makes a lot of sense here, yes. The current code will error with a ValueError on internal nul, which is pretty surprising to the user! 😬

@Icxolu Icxolu removed the CI-skip-changelog Skip checking changelog entry label Aug 13, 2024
@Icxolu Icxolu force-pushed the rename-run-eval branch 2 times, most recently from c316ff1 to 6341f90 Compare August 13, 2024 18:32
davidhewitt
davidhewitt approved these changes Aug 14, 2024
View reviewed changes
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me, thanks! (Some merge conflicts, I guess from #4436)

@Icxolu Icxolu enabled auto-merge August 15, 2024 16:47
@Icxolu Icxolu added this pull request to the merge queue Aug 15, 2024
github-merge-queue bot pushed a commit that referenced this pull request Aug 15, 2024
@Icxolu
Reintroduce Python::run and Python::eval (#4435)
4edd09c 
* reintroduce `Python::eval`

* reintroduce `Python::run`

* switch to `&CStr`
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Aug 15, 2024
@davidhewitt davidhewitt added this pull request to the merge queue Aug 15, 2024
Merged via the queue into PyO3:main with commit 9267330 Aug 15, 2024
42 checks passed
@Icxolu Icxolu deleted the rename-run-eval branch August 15, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidhewitt davidhewitt davidhewitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Icxolu @davidhewitt