Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test_misc.py for 3.13 subinterpreter changes #4426

Merged
merged 1 commit into from
Aug 10, 2024

Conversation

ngoldbaum
Copy link
Contributor

3.13b1 had some changes for the subinterpreter module since the last time this was updated.

With this change everything except for test_gevent passes in test_misc.py passes on 3.13rc1. gevent hasn't been updated for 3.13 yet. I checked with the numpy nightly wheel for numpy.

@ngoldbaum
Copy link
Contributor Author

currently this file is skipped on 3.13 because there is no subinterpreters module in the standard library

Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove the changelog entry, then this looks great to me. Thanks!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We tend to not count test changes as user-facing, no no changelog entry needed. 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now I'm free to add the label 😈

@davidhewitt davidhewitt added the CI-skip-changelog Skip checking changelog entry label Aug 9, 2024
@ngoldbaum ngoldbaum force-pushed the subinterpreter-313-changes branch from 1e5028e to f63a7ee Compare August 9, 2024 17:44
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will wait to merge until #4429 merged

@davidhewitt davidhewitt added this pull request to the merge queue Aug 9, 2024
Merged via the queue into PyO3:main with commit 847fba4 Aug 10, 2024
55 of 76 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-skip-changelog Skip checking changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants