-
Notifications
You must be signed in to change notification settings - Fork 806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert LazyTypeObject to use the Bound API #3855
Convert LazyTypeObject to use the Bound API #3855
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, good catch! Some quick thoughts and I wonder if this will benefit from #3705 being merged, which I'll go rebase now.
13b5d96
to
32cf969
Compare
CodSpeed Performance ReportMerging #3855 will improve performances by 10.2%Comparing 🎉 Hooray!
|
Benchmark | main |
LilyFoote:lazy-type-object-get-or-init-bound |
Change | |
---|---|---|---|---|
⚡ | sequence_from_list |
300 ns | 272.2 ns | +10.2% |
32cf969
to
3ed9290
Compare
@davidhewitt I think this is ready to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, indeed, thanks!
(Sorry, I opened this PR a few times but family then pulled me sideways, even though it was so short 🙈)
I found this during #3853.