Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip failing test of #239 #262

Merged
merged 2 commits into from
Nov 8, 2018
Merged

Skip failing test of #239 #262

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f847974
Add failing test for TzClass introspection
pganssle Sep 28, 2018
9ae2f1f
Skip failing test
kngwyu Nov 8, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions examples/rustapi_module/tests/test_datetime.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,3 +271,11 @@ def test_tz_class():
assert dt.tzname() == "+01:00"
assert dt.utcoffset() == pdt.timedelta(hours=1)
assert dt.dst() is None

@pytest.mark.skip(reason='to debug with the latest master')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should use pytest.mark.xfail here, not pytest.mark.skip

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.
I tried xfail now but ERROR: InvocationError for command happens. It looks pytest can't handle segfault well.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, I forgot this causes a segfault. Presumably this is why I didn't add the xfail myself in my original PR. Thanks for looking into this!

def test_tz_class_introspection():
tzi = rdt.TzClass()

assert tzi.__class__ == rdt.TzClass
assert repr(tzi) == "TzClass()"