more macro hygiene cleanup: test #[pymethods] and more arg parsing and protos #1843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
birkenfeld
force-pushed
the
pymethods_hygiene
branch
2 times, most recently
from
dd6029a to
fed4f93
Compare
birkenfeld
force-pushed
the
pymethods_hygiene
branch
from
fed4f93 to
6f75fc8
Compare
mejrs
requested changes
Aug 28, 2021
There was a problem hiding this comment.
Looks like unimplemented isn't hygienic before 1.50 - rust-lang/rust#78343
Co-authored-by: mejrs <[email protected]>
Interesting, thanks for finding that :) |
davidhewitt
approved these changes
Aug 29, 2021
There was a problem hiding this comment.
💯 awesome work on building out this test @birkenfeld @mejrs !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After this PR and the two previous ones (#1841, #1842), no non-doc usages of
pyo3::remain in the macros-backend crate or the main crate.