Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: 0.13.2 #1400

Merged
merged 1 commit into from
Feb 12, 2021
Merged

release: 0.13.2 #1400

merged 1 commit into from
Feb 12, 2021

Conversation

davidhewitt
Copy link
Member

@davidhewitt davidhewitt commented Jan 24, 2021

cc @kngwyu

This is the last release I think we need to make for the 0.13 series before we merge a number of breaking changes and start developing for 0.14. We already have breaking changes #1354 #1391 and #1398 waiting to be merged, as well as many #[deprecated] methods we could begin cleaning up.

Making this release will fix the issues with finalization which is blocking pyo3-asyncio from making a first release.

I'll try to release this on Tuesday if I don't hear otherwise. Though I think it'd be nice to merge #1393 and #1379 before we release this, so I might wait if needed.

I suggest the following release text:


This release contains small improvements over PyO3 0.13.1. The minimum supported Rust version has been lowered to Rust 1.41. A serde feature has been added which provides implementations of Serialize and Deserialize for types inside the Py<T> smart pointer.

Of note is that this release disables automatic finalization of the Python interpreter at program exit for Rust binaries embedding the Python interpreter. This was found to cause a number of issues with C extensions such as Tensorflow and Scipy which were sensitive to the deinitialization order. For the vast majority of users this should cause no impact or fix a number of problem cases. For the minority who did depend on finalization, the unsafe method with_embedded_python_interpreter has been added to manually control the interpreter lifecycle.

For full details of all changes, see the CHANGELOG.

Thank you to everyone who contributed code, documentation fixes, design ideas, bug reports, and feedback. The following users' commits are included in this release:

@alex
@awestlake87
@birkenfeld
@cfbolz
@daniil-konovalenko
@davidhewitt
@decathorpe
@ijl
@kangalioo
@kngwyu
@lazka
@nw0
@tdamsma

@awestlake87
Copy link
Contributor

I was thinking #1393 would be merged after this release since 0.13.2 would unblock the first public release of pyo3-asyncio. There are a few API doc links I'd like to add in there that would only be available after docs.rs generates them.

I could probably guess at what they would be in the meantime though, so it's up to you guys.

@davidhewitt
Copy link
Member Author

I'm flexible. The reason I'm thinking that it would be nice to merge the guide entry first, is then users who will be reading the guide at pyo3.rs/v0.13.2/ will see the new async section. Your call whether you want this, or are happy for the guide to only show on pyo3.rs/master/ (and future v0.14+ releases).

@awestlake87
Copy link
Contributor

I'm ok with merging it for 0.13.2. Like you said on the PR, the link to docs.rs should be pretty straightforward

@davidhewitt
Copy link
Member Author

Still waiting on the other PRs, which are steadily moving forward. Also the fix in #1405 seems worth including.

I'll rebase this in a few days once they're all ready.

@kngwyu
Copy link
Member

kngwyu commented Jan 27, 2021

Thanks for preparing this release!
I'm for including #1405 and #1393

@davidhewitt
Copy link
Member Author

The other PRs have now been merged; I'll rebase and release tonight unless I hear a reason not to!

@birkenfeld
Copy link
Member

I request #1420 to be decided for this release.

@davidhewitt
Copy link
Member Author

Agreed. The release can wait a little longer, I'm sure 😅

@davidhewitt davidhewitt force-pushed the release-0.13.2 branch 2 times, most recently from f120eb4 to da37e39 Compare February 11, 2021 22:14
@davidhewitt
Copy link
Member Author

davidhewitt commented Feb 11, 2021

Rebased; I'll release this tomorrow evening unless again there's reasons to wait. I'll probably merge and rebase on #1422 before doing so.

I also updated the release notes with more contributors and to mention the MSRV lowering.

@tiran
Copy link
Contributor

tiran commented Feb 12, 2021

The OpenSSL team will publish a security release on Tuesday 16th February 2021. PyCA Cryptography follows OpenSSL and releases new builds on the same day.

Would it be possible to get a new release of pyo3 out before Tuesday? PyCA Cryptography could then bump pyo3 version for the upcoming release and benefit from @birkenfeld's PR #1420. This would make Debian stable and Alpine 3.12 users happy.

CC: @alex @reaperhulk

@alex
Copy link
Contributor

alex commented Feb 12, 2021 via email

@davidhewitt
Copy link
Member Author

👍 I think this release now has everything it needs, so I'm releasing shortly. (Once CI is green.)

@davidhewitt davidhewitt merged commit 0b30904 into master Feb 12, 2021
@kngwyu
Copy link
Member

kngwyu commented Feb 13, 2021

Thanks 🎉

@messense messense deleted the release-0.13.2 branch March 18, 2021 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants