-
Notifications
You must be signed in to change notification settings - Fork 792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate functions from PEP 623 #1370
Conversation
I think we should maybe use |
I think |
I've deprecated them unconditionally and cfg'ed them out with a (not yet existing) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the other deprecations in this patch release we're using #[cfg_attr(Py_3_9, deprecated)]
.
I think I'm ok with just straight-up #[deprecated]
on these APIs, because they're intended for removal with no replacement. Many of the deprecated methods only have their replacement added on the same Python version.
Yep, as I understood https://docs.python.org/3/c-api/unicode.html and PEP 623 those methods were legacy for some time already:
|
To get the release moving I'm going to force-push a fix for the commit and merge this. Thanks very much! |
I think those are all the remaining functions scheduled for removal by PEP 623