Link python3.lib instead of python3x.lib on Windows in abi3 mode #1207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like we still rely on a few things that aren't present in |
alex
force-pushed
the
abi3-link-python3
branch
from
381904e to
15d9561
Compare
kngwyu
approved these changes
Sep 24, 2020
alex
force-pushed
the
abi3-link-python3
branch
from
15d9561 to
5960770
Compare
alex
force-pushed
the
abi3-link-python3
branch
from
5960770 to
c22dd6c
Compare
|
Ok, green now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, on windows we'd link
python35.lib(for example) which doesn't exist on other pythons of course :-)