Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start documenting abi3 support #1203

Merged
merged 1 commit into from
Oct 9, 2020
Merged

Start documenting abi3 support #1203

merged 1 commit into from
Oct 9, 2020

Conversation

alex
Copy link
Contributor

@alex alex commented Sep 20, 2020

No description provided.

@alex alex mentioned this pull request Sep 27, 2020
6 tasks
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR documents the abi3 feature, but I understood we decided to invert the pattern and instead have an unstable-abi feature which would be enabled by default?

There was a commit on the abi3 branch to this effect: 1941f4d

However that change doesn't appear to be present in the latest version of #1152 - perhaps came unstuck with a merge conflict?

@kngwyu
Copy link
Member

kngwyu commented Oct 1, 2020

I understood we decided to invert the pattern and instead have an unstable-abi feature which would be enabled by default?

I inverted the change to introduce py3*-abi3 features.

@davidhewitt
Copy link
Member

I inverted the change to introduce py3*-abi3 features.

Can you elaborate? I don't think I can see these py3*-abi3 features on that branch at the moment either.

@kngwyu
Copy link
Member

kngwyu commented Oct 1, 2020

Sorry, I meant that 'I changed it to abi3 so that it would be integrated well with py3*-abi3 features that we're going to introduce based on the discussion in #1195'

@alex
Copy link
Contributor Author

alex commented Oct 1, 2020

Yes, this documents the branch as it exists today, and I followed this documentation when I wrote the tests for setuptools-rust, so I'm sure it works :-)

Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 in that case I propose let's merge it and review everything on the abi3 branch!

@davidhewitt davidhewitt merged commit 20a93ed into PyO3:abi3 Oct 9, 2020
@alex alex deleted the abi3-docs branch October 9, 2020 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants