-
Notifications
You must be signed in to change notification settings - Fork 795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start documenting abi3 support #1203
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR documents the abi3
feature, but I understood we decided to invert the pattern and instead have an unstable-abi
feature which would be enabled by default?
There was a commit on the abi3
branch to this effect: 1941f4d
However that change doesn't appear to be present in the latest version of #1152 - perhaps came unstuck with a merge conflict?
I inverted the change to introduce |
Can you elaborate? I don't think I can see these py3*-abi3 features on that branch at the moment either. |
Sorry, I meant that 'I changed it to |
Yes, this documents the branch as it exists today, and I followed this documentation when I wrote the tests for setuptools-rust, so I'm sure it works :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 in that case I propose let's merge it and review everything on the abi3 branch!
No description provided.