-
Notifications
You must be signed in to change notification settings - Fork 792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update paste requirement from 0.1.6 to 1.0.0 #1069
Conversation
Updates the requirements on [paste](https://github.com/dtolnay/paste) to permit the latest version. - [Release notes](https://github.com/dtolnay/paste/releases) - [Commits](dtolnay/paste@0.1.6...1.0.0) Signed-off-by: dependabot-preview[bot] <[email protected]>
@kngwyu turns out that updating Should we consider bumping minimum Rust version to 1.45? |
Sounds like a pretty unnecessary bump -- paste 0.1.6 works without problems, no? |
If paste's API didn't change, maybe change the version requirements to allow both 0.1.6 and 1.0, if possible? |
I think the complication with that is we don't have a
Yes, and I agree that there's no need to bump MSRV just for this PR. However, it does raise the point that we probably should sketch out a rough policy for what MSRV bumps we do consider. I'm a fairly keen advocate for advancing MSRV forward at somewhat regular intervals. Generally this improves compile times and lets us use new features to simplify code. Although I also would not bump MSRV without a motivating reason. If we were to stick to at least current RHEL8 support, which is what we chose in #969, it updates every 3 months, most recently to 1.43.1, two days ago: https://catalog.redhat.com/software/containers/rhel8/rust-toolset/5b9c6aa85a134643ef2ecc63 By that proposal, in about 3 months time RHEL8 will ship a rust 1.45 toolset, and at that point we can make the bump and update our ecosystem? |
There's probably a similar question with Debian/Ubuntu, but don't have an idea about their release/toolchain cycles. |
I don't think this change is worth updating MRSV. |
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
Updates the requirements on paste to permit the latest version.
Commits
949f5cc
Release 1.0.008646c9
Remove unused rustflags from CI configurationba2932b
Add CI on Rust 1.31624eca6
Split item and expr position testsce0fd00
Backport to Rust 1.31072498e
Update documented minimum supported Rust version0c8b261
Document #[doc ...] pasting40db57a
Remove routes macro examplec089c81
Update readme for new APIf731b81
Merge pull request #48 from dtolnay/docDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)@dependabot use these labels
will set the current labels as the default for future PRs for this repo and language@dependabot use these reviewers
will set the current reviewers as the default for future PRs for this repo and language@dependabot use these assignees
will set the current assignees as the default for future PRs for this repo and language@dependabot use this milestone
will set the current milestone as the default for future PRs for this repo and language@dependabot badge me
will comment on this PR with code to add a "Dependabot enabled" badge to your readmeAdditionally, you can set the following in your Dependabot dashboard: