Apply suggestions from code review

Co-authored-by: Bruno Kolenbrander <[email protected]>
PyO3 · Sep 29, 2021 · efa2d85 · efa2d85
1 parent cee98e1
commit efa2d85
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/src/ffi/modsupport.rs b/src/ffi/modsupport.rs
@@ -56,9 +56,9 @@ extern "C" {
     #[cfg(Py_3_10)]
     #[cfg_attr(docsrs, doc(cfg(Py_3_10)))]
     pub fn PyModule_AddObjectRef(
-        arg1: *mut PyObject,
-        arg2: *const c_char,
-        arg3: *mut PyObject,
+        module: *mut PyObject,
+        name: *const c_char,
+        value: *mut PyObject,
     ) -> c_int;
     #[cfg_attr(PyPy, link_name = "PyPyModule_AddObject")]
     pub fn PyModule_AddObject(

diff --git a/src/ffi/object.rs b/src/ffi/object.rs
@@ -532,6 +532,7 @@ pub const Py_GE: c_int = 5;
 
 #[cfg(Py_3_10)]
 #[repr(C)]
+#[derive(Copy, Clone, Debug, PartialEq, Eq)]
 pub enum PySendResult {
     PYGEN_RETURN = 0,
     PYGEN_ERROR = -1,