Fix clippy warnings in build.rs and tests

build.rs

@@ -236,15 +236,14 @@ fn get_config_vars(python_path: &str) -> Result<HashMap<String, String>, String>
         ));
     }
     let all_vars = SYSCONFIG_FLAGS.iter().chain(SYSCONFIG_VALUES.iter());
-    let all_vars = all_vars.zip(split_stdout.iter()).fold(
-        HashMap::new(),
-        |mut memo: HashMap<String, String>, (&k, &v)| {
-            if !(v.to_owned() == "None" && is_value(k)) {
-                memo.insert(k.to_owned(), v.to_owned());
+    let all_vars = all_vars
+        .zip(split_stdout.iter())
+        .fold(HashMap::new(), |mut memo, (&k, &v)| {
+            if !(v == "None" && is_value(k)) {
+                memo.insert(k.to_string(), v.to_string());
             }
             memo
-        },
-    );
+        });
 
     Ok(fix_config_map(all_vars))
 }

guide/src/module.md

@@ -25,7 +25,7 @@ fn rust2py(py: Python, m: &PyModule) -> PyResult<()> {
 
 // logic implemented as a normal rust function
 fn sum_as_string(a:i64, b:i64) -> String {
-    format!("{}", a + b).to_string()
+    format!("{}", a + b)
 }
 
 # fn main() {}

pyo3-derive-backend/src/pyclass.rs

@@ -332,7 +332,7 @@ fn impl_class(
 
     // Enforce at compile time that PyGCProtocol is implemented
     let gc_impl = if has_gc {
-        let closure_name = format!("__assertion_closure_{}", cls.to_string());
+        let closure_name = format!("__assertion_closure_{}", cls);
         let closure_token = syn::Ident::new(&closure_name, Span::call_site());
         quote! {
             fn #closure_token() {

tests/test_dunder.rs

@@ -154,7 +154,7 @@ struct Sequence {
 impl Default for Sequence {
     fn default() -> Sequence {
         let mut fields = vec![];
-        for s in &["A", "B", "C", "D", "E", "F", "G"] {
+        for &s in &["A", "B", "C", "D", "E", "F", "G"] {
             fields.push(s.to_string());
         }
         Sequence { fields }

tests/test_module.rs

@@ -11,7 +11,7 @@ struct AnonClass {}
 struct LocatedClass {}
 
 fn sum_as_string(a: i64, b: i64) -> String {
-    format!("{}", a + b).to_string()
+    format!("{}", a + b)
 }
 
 #[pyfunction]

tests/test_pyself.rs

@@ -84,7 +84,7 @@ impl PyIterProtocol for Iter {
 fn reader() -> Reader {
     let reader = [(1, "a"), (2, "b"), (3, "c"), (4, "d"), (5, "e")];
     Reader {
-        inner: reader.iter().map(|(k, v)| (*k, v.to_string())).collect(),
+        inner: reader.iter().map(|(k, v)| (*k, (*v).to_string())).collect(),
     }
 }