Merge pull request #532 from Alexander-N/gc-default

Remove default implementation for PyGCProtocol
PyO3 · Jul 15, 2019 · 5ae014f · 5ae014f
2 parents 7e4b716 + 9c961b4
commit 5ae014f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 8 deletions.
diff --git a/src/class/gc.rs b/src/class/gc.rs
@@ -13,15 +13,9 @@ use std::os::raw::{c_int, c_void};
 pub struct PyTraverseError(c_int);
 
 /// GC support
-#[allow(unused_variables)]
 pub trait PyGCProtocol<'p>: PyTypeInfo {
-    fn __traverse__(&'p self, visit: PyVisit) -> Result<(), PyTraverseError> {
-        unimplemented!()
-    }
-
-    fn __clear__(&'p mut self) {
-        unimplemented!()
-    }
+    fn __traverse__(&'p self, visit: PyVisit) -> Result<(), PyTraverseError>;
+    fn __clear__(&'p mut self);
 }
 
 pub trait PyGCTraverseProtocol<'p>: PyGCProtocol<'p> {}

diff --git a/tests/test_gc.rs b/tests/test_gc.rs
@@ -185,6 +185,7 @@ impl PyGCProtocol for GCIntegration2 {
     fn __traverse__(&self, _visit: PyVisit) -> Result<(), PyTraverseError> {
         Ok(())
     }
+    fn __clear__(&mut self) {}
 }
 
 #[test]
-Original file line number
+Diff line change
@@ Expand Up / @@ -185,6 +185,7 @@ impl PyGCProtocol for GCIntegration2 { @@
         fn __traverse__(&self, _visit: PyVisit) -> Result<(), PyTraverseError> {
             Ok(())
         }
+        fn __clear__(&mut self) {}
     }
     #[test]
@@ Expand Down @@