Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete abi3 support with PyO3 0.13 #394

Closed
wants to merge 5 commits into from
Closed

Conversation

kngwyu
Copy link
Member

@kngwyu kngwyu commented Dec 26, 2020

Built on #383.

  • Update PyO3
  • Set PYO3_NO_PYTHON if the target is not Windows for speeding up the build
    • I think this is OK but please let me know if you have another idea

BTW, I was planning of adding an option that changes the tag name to cp3-abi3-....
But now I'm sad to know that it actually does not work with pip 😢. See pypa/packaging#261 for more.

@kngwyu
Copy link
Member Author

kngwyu commented Dec 28, 2020

I specified abi3-py36 in pyo3-pure example since cp36-abi3 wheel is installable in Python >= 3.6.

@konstin
Copy link
Member

konstin commented Jan 8, 2021

Thank you for this pull request and all the work that went into the pyo3 part! I've added windows support on top in another branch, so I'm closing this in favor of #399.

@konstin konstin closed this Jan 8, 2021
@konstin konstin deleted the pyo3-abi3-kngwyu branch March 1, 2021 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants